Skip to content
This repository has been archived by the owner on Jun 4, 2023. It is now read-only.

Fix: Speakers appear multiple times #114 #134

Closed
wants to merge 1 commit into from

Conversation

nraamat
Copy link

@nraamat nraamat commented Mar 18, 2015

Added functionality that keeps tracks of Sonos devices that already been created AirPlay servers for. Skip creating a new AirPlay server when a discovered Sonos device is a duplicate

@nraamat
Copy link
Author

nraamat commented Mar 18, 2015

This closes #114

@jeffreyameyer
Copy link

This fix removed the duplicate entry problem for me on OSX 10.10.2 and node 0.12.1.

@vkoi81
Copy link

vkoi81 commented Apr 4, 2015

Kudos to this fix. It removed my duped devices.

@jeeftor
Copy link

jeeftor commented Apr 28, 2015

Do you take into account ping time? For example I have devices listed twice, however, they have different "ping" times it would appear. +0ms +20ms for the 1st listing for example and +3ms +14ms for the 2nd listing. In my small case they happen to be in order so taking the 1st device and ignoring the 2nd entry would work - but i don't know if this is alway the case.
screen shot 2015-04-27 at 9 12 53 pm

@sjbiss
Copy link

sjbiss commented May 16, 2015

How do I install this update?

@timrettop
Copy link

I've not been able to get this change to resolve my doubled devices. I'm a bit new to node/npm, so I could be doing something wrong.

I had first installed airsonos from npm, but after finding this issue, I downloaded the source and ran npm install -g in the source directory.

I then made the changes to the main.js (leaving that commented section commented) and then re-ran the npm install -g in the source directory.

It still shows my livingroom and bedroom play1's twice.

I tried removing the airsonos (running npm remove airsonos -g) and then re-built the source, and it still shows them twice (after restarting avahi).

Should this PR make the software only print each once in its output... because I get that twice:

Searching for Sonos devices on network...
Setting up AirSonos for Master Bedroom {10.1.50.138:1400}
Setting up AirSonos for Living Room {10.1.50.120:1400}
Setting up AirSonos for Master Bedroom {10.1.50.138:1400}
Setting up AirSonos for Living Room {10.1.50.120:1400}

@JBlackCat
Copy link

@sjbiss until the pull request is merged into master, you will need to go to @nraamat page and clone their airsonos fork to your machine and run airsonos from that repository to test. Hope that helps.

@lirenzhu
Copy link

Fix for this issue should be in node-sonos, referencing stephen/node-sonos#1 here.

@leachbj
Copy link

leachbj commented Aug 6, 2015

@lirenzhu your fix works for me.

@stephen
Copy link
Owner

stephen commented Aug 9, 2015

Merged stephen/node-sonos#1 - reinstallation should solve this - thanks @lirenzhu!

@stephen stephen closed this Aug 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet