Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #8

Merged
merged 12 commits into from
Apr 18, 2021
Merged

merge #8

merged 12 commits into from
Apr 18, 2021

Conversation

stephenLYZ
Copy link
Owner

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro and others added 12 commits April 16, 2021 16:48
* First cut at adding enc type factory

* Finalized enc type factory

* Adding unit test

* PyLinting

* Adding license

* Apply suggestions from code review

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Moving things from enc -> encrypt

* CI commit

* One more fix

* Tweaking config name

* Fixing broken test

* Fixing broken test again

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* Create initial helm-release action for superset

* Add lintconf to ensure chart passes validation

* Add lint-test job

* Add apache licence headers

* Run job for master only

* Move helm-lint to separate workflow

* Helm release for master & helm dir changes only

* Dummy change to test linter
* chore: type some SQL Lab components

* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix: Add extra requires for shillelagh

* Update google-sheets.mdx

* Update index.mdx
* Switching to local codecov script

* Adding license / update instructions

* Fixing FE build

* Fixing FE codecov test
* database errors for mssql

* revisions
* chore: rename connection errors

* feat: error messages for Presto connections

* Add unit tests

* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Add chart-action submodules

* use local github actions for chart actions

* Run actions checkout for local checkout

* Run lint when PR is edited

* Remove path filter and dummy value

* Fix fetch-depth

* Test chart version bump

* Update maintainer to pass validation

* Update maintainer to pass validation
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #8 (6132563) into master (cab110e) will decrease coverage by 4.32%.
The diff coverage is 89.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   80.38%   76.05%   -4.33%     
==========================================
  Files         318      945     +627     
  Lines       25598    47916   +22318     
  Branches        0     5949    +5949     
==========================================
+ Hits        20576    36443   +15867     
- Misses       5022    11268    +6246     
- Partials        0      205     +205     
Flag Coverage Δ
hive 80.39% <89.83%> (+0.01%) ⬆️
javascript 70.25% <88.23%> (?)
mysql 80.68% <89.83%> (?)
postgres 80.71% <89.83%> (?)
python 81.09% <89.83%> (+0.71%) ⬆️
sqlite 80.32% <89.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <ø> (ø)
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 53.22% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx 89.02% <ø> (ø)
...uperset-frontend/src/components/Collapse/index.tsx 100.00% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Modal/Modal.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Modal/index.ts 100.00% <ø> (ø)
...set-frontend/src/components/ModalTrigger/index.jsx 95.65% <ø> (ø)
...src/dashboard/components/PropertiesModal/index.jsx 85.61% <ø> (ø)
...components/controls/FixedOrMetricControl/index.jsx 83.92% <ø> (ø)
... and 694 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab110e...6132563. Read the comment docs.

@stephenLYZ stephenLYZ merged commit f737fe2 into stephenLYZ:master Apr 18, 2021
stephenLYZ pushed a commit that referenced this pull request Dec 1, 2021
* build: migrate to nimbus

* fix: eslint-disable statements

* fix: conflict

* fix: lint

* fix: lints

* fix: bump packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants