Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default shared_schema options for the psql and atlas drivers #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rkrishnasanka
Copy link

@rkrishnasanka rkrishnasanka commented Mar 4, 2024

Updated the shared schema config to not default to the first schema. Verbose is better. Currently only updated the psql and atlas drivers. Related to the conversation in #187

…ose is better. Currently only updated the psql and atlas drivers.
@rkrishnasanka rkrishnasanka changed the title Updated the shared schema config to default to the first schema. Verbose is better. Currently only updated the psql and atlas drivers. Changed the default shared_schema options for the psql and atlas drivers Mar 4, 2024
@rkrishnasanka
Copy link
Author

@stephenafamo let me know if this makes sense. It'll definitely solve my be issue of an assumption that you can easily miss in the config

@stephenafamo
Copy link
Owner

It'll definitely solve my be issue of an assumption that you can easily miss in the config

I'm hesitant to change this.

Most people would only be working with one schema, and may not appreciate the extra verbosity of including the schema name when they are only working with one schema.

And while I understand that they could manually set the shared schema to get the same behaviour back, I prefer to have the "default behaviour" be as seamless as possible.

If the issue is that is is unclear what shared schema is being used, wouldn't it be more beneficial to add a log statement to make the user aware of this?

What do you think?

@rkrishnasanka
Copy link
Author

Well I guess its a reasonable alternative. I'm personally a fan of explicit specifications rather than navigating default behavior, but I understand where you might be coming from. However, you should give it some thought, having explicit verbose configs are the easiest ways of learning how processes work.

For all the people who try to deploy the tool for anything beyond the basic usage, not having explicit complete configurations is a pain to deal with. For me, it changed what I could have done in 1 hour to stretch over a week as I was trying to figure out why things weren't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants