New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List issues by milestone #301

Merged
merged 2 commits into from May 18, 2016

Conversation

Projects
None yet
4 participants
@davidCarlos
Contributor

davidCarlos commented May 18, 2016

Hey guys, i am opening this pull request to add the issues list by milestone.

With this implementation, closed milestones with open issues will be listed and open milestones without open issues, will not be listed (i would like to know if this is the right behavior).

Extract milestones correctly
 - Reuse format_issues method
@AlexChesters

This comment has been minimized.

Show comment
Hide comment
@AlexChesters

AlexChesters May 18, 2016

Contributor

LGTM! @stephencelis what do you think?

Contributor

AlexChesters commented May 18, 2016

LGTM! @stephencelis what do you think?

@stephencelis

This comment has been minimized.

Show comment
Hide comment
@stephencelis

stephencelis May 18, 2016

Owner

@AlexChesters Same! If you've done a quick test with it set and unset, please merge!

Owner

stephencelis commented May 18, 2016

@AlexChesters Same! If you've done a quick test with it set and unset, please merge!

@AlexChesters AlexChesters merged commit 134fa1d into stephencelis:master May 18, 2016

@shubhamshuklaer

This comment has been minimized.

Show comment
Hide comment
@shubhamshuklaer

shubhamshuklaer May 21, 2016

Collaborator

@davidCarlos @AlexChesters
The file ghi(In root dir) is not updated. It needs to be updated with rake build. One more question what should be the output if there are no milestones, should it output nothing(Which it is doing now) or should it just print issues normally. Technically both are correct. But I think the second one will be better. What do you think?

Collaborator

shubhamshuklaer commented May 21, 2016

@davidCarlos @AlexChesters
The file ghi(In root dir) is not updated. It needs to be updated with rake build. One more question what should be the output if there are no milestones, should it output nothing(Which it is doing now) or should it just print issues normally. Technically both are correct. But I think the second one will be better. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment