Skip to content
This repository was archived by the owner on Mar 3, 2022. It is now read-only.

List issues by milestone#301

Merged
AlexChesters merged 2 commits into
stephencelis:masterfrom
davidCarlos:list_issues_by_milestone
May 18, 2016
Merged

List issues by milestone#301
AlexChesters merged 2 commits into
stephencelis:masterfrom
davidCarlos:list_issues_by_milestone

Conversation

@davidCarlos
Copy link
Copy Markdown
Contributor

@davidCarlos davidCarlos commented May 18, 2016

Hey guys, i am opening this pull request to add the issues list by milestone.

With this implementation, closed milestones with open issues will be listed and open milestones without open issues, will not be listed (i would like to know if this is the right behavior).

 - Reuse format_issues method
@davidCarlos davidCarlos force-pushed the list_issues_by_milestone branch from 1d38995 to 83cc0ab Compare May 18, 2016 04:47
@AlexChesters
Copy link
Copy Markdown
Contributor

LGTM! @stephencelis what do you think?

@stephencelis
Copy link
Copy Markdown
Owner

@AlexChesters Same! If you've done a quick test with it set and unset, please merge!

@AlexChesters AlexChesters merged commit 134fa1d into stephencelis:master May 18, 2016
@shubhamshuklaer
Copy link
Copy Markdown
Collaborator

shubhamshuklaer commented May 21, 2016

@davidCarlos @AlexChesters
The file ghi(In root dir) is not updated. It needs to be updated with rake build. One more question what should be the output if there are no milestones, should it output nothing(Which it is doing now) or should it just print issues normally. Technically both are correct. But I think the second one will be better. What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants