Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap/unwrap function in google.protobuf.struct doesn't use snake case when --ts_proto_opt=snakeToCamel=false #579

Closed
Celend opened this issue Jun 1, 2022 · 1 comment · Fixed by #588
Closed

wrap/unwrap function in google.protobuf.struct doesn't use snake case when --ts_proto_opt=snakeToCamel=false #579

Celend opened this issue Jun 1, 2022 · 1 comment · Fixed by #588
Labels
released

Comments

@Celend
Copy link
Contributor

Celend commented Jun 1, 2022

Is ok when using camel case conversion.

protoc command:

protoc --plugin=./node_modules/.bin/protoc-gen-ts_proto  --ts_proto_out=.  \
    --ts_proto_opt=snakeToCamel=false  --ts_proto_opt=esModuleInterop=true  \
    --ts_proto_opt=env=node  \
    --proto_path ./proto/ ./proto/myfile.proto

generated code:
image
Celend pushed a commit to Celend/ts-proto that referenced this issue Jun 3, 2022
fix: Struct wrap/unwrap snake case stephenh#579
90593b6
@Celend Celend mentioned this issue Jun 3, 2022
Merged
stephenh pushed a commit that referenced this issue Jun 5, 2022
@Celend
fix: Struct wrap/unwrap snake case #579 (#588)
33f89bf 
* fix: Struct wrap/unwrap snake case #579

* test: Add more tests about struct snake case

* style: format src/main.ts

Co-authored-by: TJT <tjt@maimemo.com>
stephenh pushed a commit that referenced this issue Jun 5, 2022
@semantic-release-bot
chore(release): 1.115.4 [skip ci]
5644ec5 
## [1.115.4](v1.115.3...v1.115.4) (2022-06-05)

### Bug Fixes

* Struct wrap/unwrap snake case [#579](#579) ([#588](#588)) ([33f89bf](33f89bf))
@stephenh
Copy link
Owner

stephenh commented Jun 5, 2022

🎉 This issue has been resolved in version 1.115.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Struct wrap/unwrap snake case #579 Celend/ts-proto
2 participants
@stephenh @Celend