-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Struct wrap/unwrap snake case #579 #588
Conversation
Nice! This lgtm @Celend . To make sure we don't break this in the future, can you add a struct example to our snake-case test: https://github.com/stephenh/ts-proto/tree/main/integration/simple-snake And use the Thanks! |
there are two different types of snake case about struct: with/without oneof union, how do I test all cases? @stephenh create multiple folders in integration? |
@Celend yeah, if we needed to test both Fwiw if we can reproduce just one of those two in the existing (If that sounds right, I'm kind of skimming/reading quickly, so feel free to use better test names/etc., if I'm not 100% right on which two cases we need to cover.) |
@stephenh It can't be done in one integration test because it's control by please take a look, the test is still running and slow😭 If we want test two cases in one integration test, I think we need something like fixture that can use multiple |
Looks great, thanks @Celend ! |
🎉 This PR is included in version 1.115.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #579
please review :D