-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for FieldOptions.JSType #958
Support for FieldOptions.JSType #958
Comments
The closest configuration setting I can find is |
Hi @beyers-luno , you're right, we don't currently support Happy to have you work on a PR if you'd like to add support for it, although I'm a little worried it might be complicated, like I'm not sure the matrix of "proto type <-> different jstype". I assume that's documented somewhere, but just might be tedious to handle all of the cases. Would be great if you want to take a look though; thanks! |
I'd be willing to take a stab at this |
@dasco144 sounds good! I think the Unfortunately that's just the type, and the encoding/decoding of that type is probably scattered around the encode/decode/toJSON/fromJSON methods. Like |
@stephenh I've got an PR ready for review 🙏 |
Closes #958 --------- Co-authored-by: Daniel Santiago <dsantiago@luno.com>
🎉 This issue has been resolved in version 1.173.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reference: https://protobuf.dev/reference/java/api-docs/com/google/protobuf/DescriptorProtos.FieldOptions.JSType
Hi!
In my proto file I have:
In my generated ts file I get:
Using the arguments:
It should be this?
Is there a configuration setting I am missing?
The text was updated successfully, but these errors were encountered: