Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map marker use InfoWindow #192

Closed
ryskajakub opened this issue Jun 7, 2014 · 3 comments
Closed

Map marker use InfoWindow #192

ryskajakub opened this issue Jun 7, 2014 · 3 comments

Comments

@ryskajakub
Copy link
Contributor

I tried to use the tooltip feature on the map of the plugin, but it didn't work, when I clicked on the marker, nothing poped up. I went through the code and it looks like there is a custom solution - the function in frontend.js https://github.com/stephenharris/Event-Organiser/blob/master/js/frontend.js#L535. But the google apis already have this functionality covered with this https://developers.google.com/maps/documentation/javascript/reference?hl=cs#InfoWindow class.

Wouldn't it be better to use the google's solution? I've already coded it in my fork so I can open a pull request.

@stephenharris
Copy link
Owner

The original motivation for using QTip2, was that it allowed for more fine-grain control of appearance and behaviour. Additionally, at the time, Google map's InfoWindow was very, very ugly.

It does appear better now, so I'd welcome a pull-request. I'll take a look and see what I think. (It would additionally simplify the code).

In the mean time, regarding the tooltips not appearing, I'll take a look. The only known issue is when the theme uses an old version of masonry. (i.e. the version shipped with WordPress prior to 3.8/3.9 (I forget which)).

@ryskajakub
Copy link
Contributor Author

I use wp 3.9, so this is probably something different. I didn't study the error so much as I have realized, that there is the possibility to use the InfoWindow. I might report the problem in a more detailed way if you won't be able to reproduce it.

@ryskajakub
Copy link
Contributor Author

I looked at the frontend.js file and it looks like there are mixed codes for indentation, there are tabs(09) and spaces(20). I think it would be better to stick to one. The wordpress codex preferes tabs. Should I go with tabs?

ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 24, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 24, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 24, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
ryskajakub added a commit to ryskajakub/Event-Organiser that referenced this issue Jun 29, 2014
@stephenharris stephenharris added this to the 3.2.0 milestone Jul 9, 2016
@stephenharris stephenharris removed this from the 3.2.0 milestone Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants