Include skip_methods option to avoid collecting metrics for specific methods #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Adds an option to avoid collecting metrics on request with specific methods.
This option can be used to avoid collecting metrics on, for example, communication description requests for endpoints (but can be used in any other method).
The new option is an optional list called
skip_methods
.Example:
On the justification
We have an application using microservices architecture, at the beginning of which there is a gateway that forwards requests with a given path or method. From this point, we monitor the metrics. Prometheus is not able to process such a large generated traffic, which we already reduce by ignoring some paths, so we also want to reduce it by ignoring requests containing some methods (namely
OPTIONS
), because they are not important to us. This change may allow us to get a performance benefit. I will be very pleased with the opportunity to contribute to your project.@stephenhillier