Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp-git breaks in Node 9.5.0. #179

Closed
pford68 opened this issue Feb 15, 2018 · 3 comments
Closed

gulp-git breaks in Node 9.5.0. #179

pford68 opened this issue Feb 15, 2018 · 3 comments

Comments

@pford68
Copy link

pford68 commented Feb 15, 2018

The issue appears to be require-dir dependency. The latter appears to be a known issue in Node v8 and up, and it seems to affect several modules that use require-dir.

TypeError: require.extensions.hasOwnProperty is not a function
    at requireDir (/Users/paford/Projects/D-F/mjs-microservices/node_modules/gulp-git/node_modules/require-dir/index.js:93:37)
    at Object.<anonymous> (/Users/paford/Projects/D-F/mjs-microservices/node_modules/gulp-git/index.js:4:18)
@stephenlacy
Copy link
Owner

Does require-dir 1.0.0 fix this if you know?
require-dir build is passing just fine on 9.5.0: https://travis-ci.org/aseemk/requireDir/jobs/338757106

@pford68
Copy link
Author

pford68 commented Feb 19, 2018

@stevelacy Yes, it appears that 1.0.0 does fix it.

@stephenlacy
Copy link
Owner

Sounds good, I'll update the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants