Django 2.2 compatibility #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 9, 2019 17:04
Fixed reverse URL import.
…nto 2.2-compat
Fix invoice links in admin
|
Most of this issues should be fixed in version 1.0.0b1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cartridge and mezzanine have some issues with Django 2.2 this PR aims to fix that.
In order to pass tests (and generally work) Mezzanine and filebrowser_safe also need modifications. I have test versions of these available at github.com/fermorltd/mezzanine@2.2-compat and github.com/fermorltd/filebrowser-safe@2.2-compat respectively. (I hope to make PR's for these when I am sure they are completely clean of any bespoke code)
All tests pass but this is my first shot at this so feedback / code review is welcome.
EDIT: Might be worth noting that this will probably break if using a namespace is not 'shop' for the app as URLs that were previously reversed without them (like this) will no longer work.