Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class*="collapse" matches even collapse-closed, unwanted behavior #1987

Closed
wants to merge 1 commit into from

Conversation

dbischof
Copy link
Contributor

@dbischof dbischof commented May 4, 2021

In:

$('fieldset[class*="collapse"]').each(function() {
    $(this).addClass("collapse-open");
    $(this).removeClass("collapse");
});

$('fieldset[class*="collapse-closed"]') matches <fieldset class="module aligned collapse-closed"/>, which leads it to add the collapse-open class. This in turn means collapse-closed and collapse-open always toggle in tandem rather than flopping between each other as intended.

@jerivas jerivas added this to To do in Mezzanine 5 Jul 19, 2021
@jerivas
Copy link
Collaborator

jerivas commented Jul 21, 2021

I'm unable to reproduce this on the latest master branch. Can you provide your admin class fieldsets?

@jerivas jerivas moved this from To do to In progress in Mezzanine 5 Jul 21, 2021
@jerivas jerivas closed this in 95b138a Jul 21, 2021
Mezzanine 5 automation moved this from In progress to Done Jul 21, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mezzanine 5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants