You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pcarbo Hi Peter -- I just had a great meeting with Nick today, and we have the following question about including published external data in LDshrink package. We would appreciate your input.
To make the package user-friendly, we would like to include the following external data files:
Genetic maps from 1000 Genomes: ftp://ftp.1000genomes.ebi.ac.uk/vol1/ftp/technical/working/20130507_omni_recombination_rates/
These data files have fairly simple structure. The genetic maps are data frames with the following headers:
[id] [physical position] [genetic position (cumulative)]
The LD blocks are data frames with the following headers:
[chromosome name] [region start] [region stop]
These data files also have formal publications available. I wonder if we could include these external files in LDshrink package, provided that we explicitly cite these publications?
Do we have to worry about licensing issues?
An alternative plan is to provide users with the data preprocessing scripts/functions, but I think this will make the package harder to use.
The text was updated successfully, but these errors were encountered:
@xiangzhu@CreRecombinase I don't see any issue in adding these data to the R package as long as you make sure to cite the original sources.
For ease of use, I would recommend that you add .RData files to the data folder inside the package. See here for an example of this. See also the files in the man folder for an example of how these data sets were documented in the package. (You can also document data sets with roxygen2.)
Update: Nick and I decided not include the "approximately independent LD blocks" in LDshrink (at least in this stage), since adding these blocks might complicate the implementation and confuse people.
We are still using these blocks in some projects. Perhaps we can have a vignette showing how to use LDshrink and these blocks together?
@pcarbo Hi Peter -- I just had a great meeting with Nick today, and we have the following question about including published external data in
LDshrink
package. We would appreciate your input.To make the package user-friendly, we would like to include the following external data files:
Genetic maps from 1000 Genomes: ftp://ftp.1000genomes.ebi.ac.uk/vol1/ftp/technical/working/20130507_omni_recombination_rates/
Approximately independent LD blocks: https://bitbucket.org/nygcresearch/ldetect-data/src
These data files have fairly simple structure. The genetic maps are data frames with the following headers:
The LD blocks are data frames with the following headers:
These data files also have formal publications available. I wonder if we could include these external files in
LDshrink
package, provided that we explicitly cite these publications?Do we have to worry about licensing issues?
An alternative plan is to provide users with the data preprocessing scripts/functions, but I think this will make the package harder to use.
The text was updated successfully, but these errors were encountered: