Preserve event timestamps in X11 input driver #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X11 XKeyEvent structure (and others) include a timestamp field, with 1ms resolution. This was previously ignored causing the input timestamps to be set to the middle of each frame. If the timestamps are passed through then the event timestamps are not coupled to the framerate and the polling issues are resolved.
|
You write these changes have been tested on Linux Mint, for IPAC, JPAC, and keyboard. I have an SMX Platform, what would it take to test for these as well? |
|
This is X11 only, so essentially Linux only (I assume the OSX build doesn't use X11 for input, but if someone built on freebsd/similar it probably would) For the SMX platform you'll need to confirm whether it's using the X11 input driver. I would expect SMX to be registered as a joystick by the system, so would use one of the other input drivers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X11 XKeyEvent structure (and others) include a timestamp
field, with 1ms resolution.
This was previously ignored causing the input timestamps to be
set to the middle of each frame.
If the timestamps are passed through then the event timestamps are
not coupled to the framerate and the polling issues are resolved.
So far these changes have been tested on Linux Mint, for IPAC, JPAC, and keyboard. No issues have been identified (and several quads have been achieved without any of the previously noted polling issues)