Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MusicWheel:GetCurrentSections() #2002

Merged
merged 3 commits into from May 28, 2020

Conversation

RhythmLunatic
Copy link
Contributor

Necessary for using a custom group select along with the built in music select since SONGMAN:GetSongGroupNames() does not have any concept of the currently used sort.

Also needed to get the number of groups in the group select when the sort is not default.

@quietly-turning
Copy link
Contributor

Thanks for working on this!

What differentiates a Section in the MusicWheel from a Current Section?

@RhythmLunatic
Copy link
Contributor Author

I suppose there is no difference, but in my head current sort = currently generated sections.
I will change it to GetSections() instead since there is no "current sections" in the rest of the code, whatever sections exist are the current ones.

@quietly-turning
Copy link
Contributor

Ah, okay, that makes more sense. Thanks for clarifying.

I don't think you need to change anything. I might include more description as part of my ongoing mess in #1997 eventually.

@quietly-turning
Copy link
Contributor

Following recent convention, I'll leave this open for 24 hours to see if there is feedback from anyone else. Assuming there's no opposition, I'll merge tomorrow.

@RhythmLunatic
Copy link
Contributor Author

In that case I will leave the function name as-is.

@quietly-turning quietly-turning merged commit b3bd9a3 into stepmania:5_1-new May 28, 2020
@RhythmLunatic RhythmLunatic deleted the GetCurrentSection branch June 12, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants