Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Missing Translations #1696

Merged
merged 14 commits into from
Feb 10, 2024
Merged

Update Missing Translations #1696

merged 14 commits into from
Feb 10, 2024

Conversation

daGscheid
Copy link
Member

Solving #862

@mabasian
Copy link
Contributor

mabasian commented Feb 9, 2024

Persian language need some edition. Should I approve it before or after edit? @daGscheid

@daGscheid
Copy link
Member Author

Persian language need some edition. Should I approve it before or after edit? @daGscheid

After I'd say

@mabasian
Copy link
Contributor

mabasian commented Feb 9, 2024

Persian language need some edition. Should I approve it before or after edit? @daGscheid

After I'd say

Could you please change the status of the pull request to draft? I will clone your branch tomorrow and make the necessary edits. 😄

@daGscheid daGscheid marked this pull request as draft February 9, 2024 23:07
@mabasian
Copy link
Contributor

✅ Done!

@mabasian mabasian marked this pull request as ready for review February 10, 2024 11:32
Copy link
Contributor

@mabasian mabasian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mabasian mabasian merged commit fb56f49 into main Feb 10, 2024
7 checks passed
@daGscheid daGscheid deleted the translation-updates branch February 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants