Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: export all logs in the log page #1899

Merged
merged 8 commits into from
Jun 3, 2024
Merged

FIX: export all logs in the log page #1899

merged 8 commits into from
Jun 3, 2024

Conversation

mabasian
Copy link
Contributor

@mabasian mabasian commented May 29, 2024 •
edited
Loading

fix #1884

NeoPlays
NeoPlays requested changes May 29, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think all of this duplicated code is needed

NeoPlays
NeoPlays reviewed May 29, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what i mean

launcher/src/backend/Monitoring.js Outdated Show resolved Hide resolved
launcher/src/components/UI/node-page/NodeScreen.vue Outdated Show resolved Hide resolved
@mabasian mabasian marked this pull request as draft May 29, 2024 17:16
@mabasian
Copy link
Contributor Author

@NeoPlays The updateAndExportAllLogs and getAllServiceLogs functions have been updated to ensure they work with a single button click. Please review the changes when you get a chance.

@mabasian mabasian requested a review from NeoPlays May 30, 2024 08:44
@mabasian mabasian marked this pull request as ready for review May 30, 2024 10:09
NeoPlays
NeoPlays approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@NeoPlays NeoPlays merged commit 7adb04e into stereum-dev:main Jun 3, 2024
3 checks passed
@mabasian mabasian deleted the logBug branch June 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoPlays NeoPlays NeoPlays approved these changes

@MaxTheGeeek MaxTheGeeek Awaiting requested review from MaxTheGeeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Export all Logs exports only 150 lines
2 participants
@mabasian @NeoPlays