Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: ssv-key-generator role #223

Merged
merged 15 commits into from
May 10, 2022
Merged

ADD: ssv-key-generator role #223

merged 15 commits into from
May 10, 2022

Conversation

gbayasgalan
Copy link
Contributor

@gbayasgalan gbayasgalan commented Apr 29, 2022 •
edited

@stefa2k stefa2k mentioned this pull request May 3, 2022
Closed
@gbayasgalan gbayasgalan requested a review from stefa2k May 6, 2022 10:06
@gbayasgalan gbayasgalan requested a review from stefa2k May 6, 2022 12:51
stefa2k
stefa2k requested changes May 7, 2022
View reviewed changes
Copy link
Member

@stefa2k stefa2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments for ssv-lighthouse also apply to other ssv-* scenarios

controls/roles/manage-service/molecule/ssv-lighthouse/converge.yml Show resolved Hide resolved
controls/roles/manage-service/molecule/ssv-lighthouse/converge.yml Outdated Show resolved Hide resolved
controls/roles/manage-service/molecule/ssv-lighthouse/prepare.yml Show resolved Hide resolved
@gbayasgalan gbayasgalan requested a review from stefa2k May 8, 2022 16:36
@stefa2k stefa2k mentioned this pull request May 9, 2022
Open
stefa2k
stefa2k approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@stefa2k stefa2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@stefa2k stefa2k merged commit 15c6b1b into stereum-dev:main May 10, 2022
@gbayasgalan gbayasgalan deleted the ssvkey branch May 10, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefa2k stefa2k stefa2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gbayasgalan @stefa2k