remove a weird special case in path traversal #20

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
1 participant
Collaborator

doy commented Dec 27, 2012

Previously, given

my $c = container 'Foo', as {
container 'Bar', as {
service 'Baz' => (value => 1);
};
};

you could do $c->fetch('/Foo/Foo/Bar/Bar/Bar/Baz') and still get out the
Baz service, because giving the name of the current container as a path
component was treated as a no-op. This doesn't actually make any sense,
is fairly confusing, and required extra code to implement it as a
special case, so I'm not sure why it was behaving that way at all
originally. So, remove it.

doy added some commits Dec 27, 2012

@doy doy remove a weird special case in path traversal
Previously, given

  my $c = container 'Foo', as {
      container 'Bar', as {
          service 'Baz' => (value => 1);
      };
  };

you could do $c->fetch('/Foo/Foo/Bar/Bar/Bar/Baz') and still get out the
Baz service, because giving the name of the current container as a path
component was treated as a no-op. This doesn't actually make any sense,
is fairly confusing, and required extra code to implement it as a
special case, so I'm not sure why it was behaving that way at all
originally. So, remove it.
950fb70
@doy doy turn this into a deprecation warning 215841c
@doy doy test the deprecation warning 1ed1a71
Collaborator

doy commented Jan 2, 2013

Alright, updated this pull request to turn it into a deprecation warning for now.

Collaborator

doy commented Jan 28, 2013

Any thoughts on this?

Collaborator

doy commented Aug 1, 2013

Merged.

doy closed this Aug 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment