remove a weird special case in path traversal #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, given
my $c = container 'Foo', as {
container 'Bar', as {
service 'Baz' => (value => 1);
};
};
you could do $c->fetch('/Foo/Foo/Bar/Bar/Bar/Baz') and still get out the
Baz service, because giving the name of the current container as a path
component was treated as a no-op. This doesn't actually make any sense,
is fairly confusing, and required extra code to implement it as a
special case, so I'm not sure why it was behaving that way at all
originally. So, remove it.
|
Alright, updated this pull request to turn it into a deprecation warning for now. |
|
Any thoughts on this? |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, given
my $c = container 'Foo', as {
container 'Bar', as {
service 'Baz' => (value => 1);
};
};
you could do $c->fetch('/Foo/Foo/Bar/Bar/Bar/Baz') and still get out the
Baz service, because giving the name of the current container as a path
component was treated as a no-op. This doesn't actually make any sense,
is fairly confusing, and required extra code to implement it as a
special case, so I'm not sure why it was behaving that way at all
originally. So, remove it.