Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dread Barrage #6

Closed
qwe8585 opened this issue Feb 10, 2021 · 16 comments
Closed

Dread Barrage #6

qwe8585 opened this issue Feb 10, 2021 · 16 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@qwe8585
Copy link

qwe8585 commented Feb 10, 2021

Hello there Steve!

Keep up the good work!

I know this is pretty tall order but I couldn't make the event tab work with the new event "Dread Barrage".

Could you please check it?

qwe8585.

@steve1316
Copy link
Owner

The Event Farming Mode pertains to Events where there are farmable trade-in items like "Elegy Auld Lang Syne" and "A Tale of Kindled Bonds". The others, like Guild Wars, ROTB, and Dread Barrage, are currently not supported. Sorry for the misunderstanding.

I will work on support for Dread Barrage tomorrow.

@steve1316
Copy link
Owner

Just pushed several updates such that the bot now supports Dread Barrage and fighting Unparalleled Foes. Let me know how it goes!

@qwe8585
Copy link
Author

qwe8585 commented Feb 12, 2021

Thanks Steve it works!

But can we get support for pending battles like we have in raid battles?

@qwe8585
Copy link
Author

qwe8585 commented Feb 12, 2021

Another observation steve there is this popup:
image
when the battle ends the bot gets stuck on it

@qwe8585
Copy link
Author

qwe8585 commented Feb 12, 2021

Another another observation is that when the battle ends in dread barrage the script gets stuck on the
image loot collected check but it actually clicks away all the popups.

@steve1316
Copy link
Owner

Thank you for letting me know about these new bugs.

I was able to replicate the lack of support for pending battles during Dread Barrage and a fix will be out soon.

For the issue of "This battle has ended" during Combat Mode, did it occur while you were the only person inside that Dread Barrage mission or were there others with you?

Additionally, for the issue of the infinite loop when collecting loot, did you happen to save the text log from when it happened? Did you also happen to take a screenshot of the game screen? Having these available would greatly help me in pinpointing the issue.

steve1316 added a commit that referenced this issue Feb 13, 2021
- Also prevented the incrementing of the amount of runs so far when collecting from Pending Battles because there is no certainty that a Pending Battle is the same mission that you are currently farming.
@steve1316
Copy link
Owner

Just posted a fix for the lack of support for Pending Battles during a Dread Barrage Raid. I have not been able to replicate the other 2 issues as I need more information.

I suspect that Commit 429b7b0 may have also fixed your infinite looping on trying to confirm the location at the "Loot Collected" screen. Let me know how it works out for you!

steve1316 added a commit that referenced this issue Feb 13, 2021
- This is temporary as the specifics on how this happens is still unknown and I have not been able to replicate the issue. For now, the bot will attempt to match for the "Battle Concluded" header image provided by a user. Due to how the image is scaled on their computer, this may not work for others.
@steve1316
Copy link
Owner

Made a temporary fix in Commit 9efca4d to attempt to address the issue of "This battle has ended" during Combat Mode. I have not been able to replicate the same issue in my tests so I am unsure if this fix will work or not.

@qwe8585
Copy link
Author

qwe8585 commented Feb 13, 2021

Thanks a bunch Steve for the heads ups.

I will try to save as many pictures and logs as I can. I will get on with testing the newest changes.

@qwe8585
Copy link
Author

qwe8585 commented Feb 13, 2021

Oh my Steve I just got it. In dread barrage as long as you have one raid started by you can't start another one. I don't know if this for all raids in GBF cause I'm kind of a noob. So maybe the pending battle system won't work out so well. Sorry about that one.

@qwe8585
Copy link
Author

qwe8585 commented Feb 13, 2021

I can confirm it that the loot loop is gone Steve.

@steve1316
Copy link
Owner

steve1316 commented Feb 13, 2021

Yes, that is correct. Once you host a quest/raid, you cannot host anything else until you complete it or retreat from it. But for joining raids, you can join up to a max of 3 raids without worry.

Looking at the log that you posted earlier, turns out you wiped during Combat Mode and the bot tried to retreat but failed. That is a bug that only could have come to light because you provided the logs for it so thank you! It seems to be the main source of trouble as to why you thought it must have been a Pending Battle issue.

To correct a misunderstanding, what the system does for Pending Battles is that it checks for raids that were joined (not hosted) and completed successfully and collects any pending rewards from them. This is because once you get to I believe 5 or 7 Pending Battles waiting to be collected from, the game will prevent you from doing anything until you collect from them and reduce the number of Pending Battles below the limit.

I will be posting a fix for the retreat bug soon.

@qwe8585
Copy link
Author

qwe8585 commented Feb 13, 2021

Yeah thanks for clearing that up Steve.

@steve1316
Copy link
Owner

Posted a new update that overhauled the logic for checking if the party wiped or not.

@qwe8585
Copy link
Author

qwe8585 commented Feb 16, 2021

Sorry Steve I'm going off topic here.

How many shiny slime searches can you do in 1 hour?

@steve1316
Copy link
Owner

On Very Hard, I can do 25 on my virtual machine while in Full Auto. Additionally, I do not have Sarasa or Swordmaster.

I will be closing this issue as Dread Barrage is now over.

@steve1316 steve1316 self-assigned this Feb 21, 2021
@steve1316 steve1316 added bug Something isn't working enhancement New feature or request labels Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants