This repository has been archived by the owner on Aug 27, 2023. It is now read-only.
Add flag to pypicloud-gen-password for reading password from stdin #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Merged into the 1.1 branch. |
|
Thanks, closing PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature would be used for scripting the password hash creation. The specific use case I have in mind is to generate the hashed password from a Kubernetes secret using an init container before starting pypicloud.
The equivalent functionality is also available with the
mkpasswdcommand which is part of thewhoispackage, (mkpasswd -m sha-512 -s -R 20500) but it makes sense for thepypicloud-gen-passwordutility to support it as well.