Bunch -> Webpack #32
Merged
Bunch -> Webpack #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevegrossi
force-pushed
the
stevegrossi/brunch-to-webpack
branch
3 times, most recently
from
118cba7
to
586d34d
Compare
I’m following https://gist.github.com/chrismccord/bb1f8b136f5a9e4abc0bfc07b832257e ~~Current~~ issues: - SCSS changes aren’t reflected in the browser - `ReferenceError: require is not defined` in the console, but JS still works. I get another error, `Error: Cannot find module 'web/static/js/app' from ‘/‘` on master, so this may be related to a pre-existing issue. This helped me get SCSS working: https://elixirforum.com/t/phoenix-1-3-to-1-4-migrating-from-brunch-to-webpack/17820/4 And the `require()` script I had in application.html.eex doesn’t appear necessary and isn’t present in new phoenix 1.4 apps, so I’m not sure where it came from.
stevegrossi
force-pushed
the
stevegrossi/brunch-to-webpack
branch
from
586d34d
to
4e60a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m following https://gist.github.com/chrismccord/bb1f8b136f5a9e4abc0bfc07b832257e
Issues to Resolve
import css from '../css/app.css';fails, as the link above does not get into using SCSSReferenceError: require is not definedin the console, but JS still works. I get another error,Error: Cannot find module 'web/static/js/app' from ‘/‘on master, so this may be related to a pre-existing issue.