Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus3): added service.additionalPorts.hosts for multi-hosts support #982

Conversation

djerfy
Copy link
Contributor

@djerfy djerfy commented Jun 14, 2024

Added service.additionalPorts.hosts for multi-hosts support.

By example:

  additionalPorts:
     - port: 8082
       name: docker-group
       containerPort: 8082
       hosts:
         - nexus-docker.local
     - port: 8083
       name: docker-hosted
       containerPort: 8083
       hosts:
         - nexus-docker-hosted-1.local
         - nexus-docker-hosted-2.local

Also service.additionalPorts.host is now deprecated.

Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @djerfy. I've added a comment and could you please also update the README to show the changes?

charts/nexus3/templates/ingress.yaml Outdated Show resolved Hide resolved
charts/nexus3/values.yaml Show resolved Hide resolved
@djerfy
Copy link
Contributor Author

djerfy commented Jun 14, 2024

Thanks for the PR @djerfy. I've added a comment and could you please also update the README to show the changes?

Sure

@djerfy djerfy force-pushed the feat/nexus3-additionalports-multi-hosts branch from c30185f to 4f64c29 Compare June 14, 2024 15:44
Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djerfy thanks for making the changes. Could I also ask you to update the additionalPorts config in ci/kubeconform.yaml to use hosts and to add a value for additionalPorts to ci/ci-values.yaml using hosts?

charts/nexus3/values.yaml Show resolved Hide resolved
@djerfy djerfy force-pushed the feat/nexus3-additionalports-multi-hosts branch from 4f64c29 to 9f3420b Compare June 25, 2024 18:32
Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djerfy could you rebase and squash your commits?

@djerfy djerfy force-pushed the feat/nexus3-additionalports-multi-hosts branch 2 times, most recently from 69587fc to 1a3de79 Compare July 2, 2024 17:28
@djerfy
Copy link
Contributor Author

djerfy commented Jul 2, 2024

Thanks @djerfy could you rebase and squash your commits?

Done, thanks

Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make sure you've tested this locally, even if it's just with helm template.

charts/nexus3/templates/ingress.yaml Outdated Show resolved Hide resolved
@djerfy djerfy force-pushed the feat/nexus3-additionalports-multi-hosts branch 2 times, most recently from 9638ecd to e2deaba Compare July 5, 2024 17:39
…pport

Signed-off-by: djerfy <djerfy@gmail.com>
@djerfy djerfy force-pushed the feat/nexus3-additionalports-multi-hosts branch from e2deaba to 688daf5 Compare July 5, 2024 17:43
@stevehipwell
Copy link
Owner

@djerfy I'll re run the workflow when norwoodj/helm-docs#250 has been resolved.

Copy link
Owner

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @djerfy and for working with me to make this pattern the chart default. 🥳

@stevehipwell stevehipwell merged commit 31a1e3b into stevehipwell:main Jul 8, 2024
1 check passed
@djerfy djerfy deleted the feat/nexus3-additionalports-multi-hosts branch July 9, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants