-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nexus3): added service.additionalPorts.hosts for multi-hosts support #982
feat(nexus3): added service.additionalPorts.hosts for multi-hosts support #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @djerfy. I've added a comment and could you please also update the README to show the changes?
Sure |
c30185f
to
4f64c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djerfy thanks for making the changes. Could I also ask you to update the additionalPorts
config in ci/kubeconform.yaml to use hosts
and to add a value for additionalPorts
to ci/ci-values.yaml using hosts
?
4f64c29
to
9f3420b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djerfy could you rebase and squash your commits?
69587fc
to
1a3de79
Compare
Done, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make sure you've tested this locally, even if it's just with helm template
.
9638ecd
to
e2deaba
Compare
…pport Signed-off-by: djerfy <djerfy@gmail.com>
e2deaba
to
688daf5
Compare
@djerfy I'll re run the workflow when norwoodj/helm-docs#250 has been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @djerfy and for working with me to make this pattern the chart default. 🥳
Added
service.additionalPorts.hosts
for multi-hosts support.By example:
Also
service.additionalPorts.host
is now deprecated.