Skip to content

Commit

Permalink
Enable -Wshadow by default
Browse files Browse the repository at this point in the history 
The code base is almost shadow-free now, so this won't add much noise to the compiles.
Problems I know about:
 lxt{,2}_write.c:  patch sent upstream
 cflexor.c:  exposes gray area of name space boundary
  • Loading branch information
@ldoolitt @steveicarus
ldoolitt authored and steveicarus committed Dec 30, 2008
1 parent b76c14e commit 31d67fc
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion Makefile.in
View file
Expand Up @@ -81,7 +81,7 @@ PS2PDF = @PS2PDF@
GIT = @GIT@

CPPFLAGS = @DEFS@ -I. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@
CXXFLAGS = -Wall @CXXFLAGS@
CXXFLAGS = -Wall -Wshadow @CXXFLAGS@
PICFLAGS = @PICFLAG@
LDFLAGS = @rdynamic@ @LDFLAGS@

Expand Down
2 changes: 1 addition & 1 deletion cadpli/Makefile.in
View file
Expand Up @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I$(srcdir) -I$(srcdir)/.. -I.. @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

SHARED = @shared@
Expand Down
2 changes: 1 addition & 1 deletion driver-vpi/Makefile.in
View file
Expand Up @@ -44,7 +44,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: iverilog-vpi@EXEEXT@
Expand Down
2 changes: 1 addition & 1 deletion driver/Makefile.in
View file
Expand Up @@ -44,7 +44,7 @@ MAN = @MAN@
PS2PDF = @PS2PDF@

CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep iverilog@EXEEXT@
Expand Down
2 changes: 1 addition & 1 deletion ivlpp/Makefile.in
View file
Expand Up @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: ivlpp@EXEEXT@
Expand Down
2 changes: 1 addition & 1 deletion libveriuser/Makefile.in
View file
Expand Up @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I. -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@
RANLIB = @RANLIB@

Expand Down
2 changes: 1 addition & 1 deletion tgt-fpga/Makefile.in
View file
Expand Up @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep fpga.tgt
Expand Down
2 changes: 1 addition & 1 deletion tgt-null/Makefile.in
View file
Expand Up @@ -37,7 +37,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep null.tgt
Expand Down
2 changes: 1 addition & 1 deletion tgt-pal/Makefile.in
View file
Expand Up @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep pal.tgt
Expand Down
2 changes: 1 addition & 1 deletion tgt-stub/Makefile.in
View file
Expand Up @@ -38,7 +38,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep stub.tgt
Expand Down
2 changes: 1 addition & 1 deletion tgt-verilog/Makefile.in
View file
Expand Up @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = @ident_support@ -I.. -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep verilog.tgt
Expand Down
2 changes: 1 addition & 1 deletion tgt-vhdl/Makefile.in
View file
Expand Up @@ -39,7 +39,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@
CXXFLAGS = -Wall @CXXFLAGS@
CXXFLAGS = -Wall -Wshadow @CXXFLAGS@
LDFLAGS = @LDFLAGS@

all: dep vhdl.tgt vhdl.conf vhdl-s.conf
Expand Down
2 changes: 1 addition & 1 deletion tgt-vvp/Makefile.in
View file
Expand Up @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@
INSTALL_DATA = @INSTALL_DATA@

CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep vvp.tgt vvp.conf vvp-s.conf
Expand Down
2 changes: 1 addition & 1 deletion vpi/Makefile.in
View file
Expand Up @@ -42,7 +42,7 @@ LEX = @LEX@
YACC = @YACC@

CPPFLAGS = -I. -I$(srcdir)/.. -I$(srcdir) -I.. @file64_support@ @CPPFLAGS@ @DEFS@ @PICFLAG@
CFLAGS = -Wall @CFLAGS@
CFLAGS = -Wall -Wshadow @CFLAGS@
LDFLAGS = @LDFLAGS@

all: dep system.vpi va_math.vpi v2005_math.vpi $(ALL32)
Expand Down
2 changes: 1 addition & 1 deletion vvp/Makefile.in
View file
Expand Up @@ -48,7 +48,7 @@ MAN = @MAN@
PS2PDF = @PS2PDF@

CPPFLAGS = -I. -I.. -I $(srcdir) -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@
CXXFLAGS = -Wall @CXXFLAGS@
CXXFLAGS = -Wall -Wshadow @CXXFLAGS@
LDFLAGS = @rdynamic@ @LDFLAGS@
LIBS = @LIBS@ @EXTRALIBS@

Expand Down

0 comments on commit 31d67fc

Please sign in to comment.