Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ratijas
Copy link

@ratijas ratijas commented Dec 8, 2021

It was done for compile_commands.json cleanup in the first place.
Other entries were copied from KDE/marble repo as well.

See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86

It was done for compile_commands.json cleanup in the first place.
Other entries were copied from KDE/marble repo as well.

See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86
@ratijas
Copy link
Author

ratijas commented Dec 14, 2021

@steveire ping

@ratijas
Copy link
Author

ratijas commented Dec 22, 2021

Ping, @steveire. Are you OK?

@ratijas
Copy link
Author

ratijas commented Dec 26, 2021

Classical open source project: 1400+ commits repo, and one dead maintainer. I do hope he's alright tho~

@kossebau do you happen to have a commit access?

@dantti
Copy link
Contributor

dantti commented Dec 26, 2021

Classical open source project: 1400+ commits repo, and one dead maintainer. I do hope he's alright tho~

@kossebau do you happen to have a commit access?

Yes, this is the beauty of open source, you can just grab his code and do whatever you like with it as long as allowed by it's license, so far the author doesn't have time for this anymore and only eventually he merges patches, there's a ongoing process to import it in KDE libs, I forked this as Cutelee which might the merged back to the eventual KDE libs import, you can also fork it, afaik no one else has commit access.

@ratijas
Copy link
Author

ratijas commented Dec 26, 2021

Forks are always expensive because of multiple technical and social reasons. They are the last resort when nothing else is effective.

Good to know it's being worked on, though. Unfortunately, it also means that I can't fully close the issue on invent until the patch is applied.

@kossebau
Copy link
Contributor

@kossebau do you happen to have a commit access?

Nope, this here on Github is all Stephen's domain. BTW, he is aware of the state, thus already two years proposed in December 2019 to include Grantlee into KDE Frameworks: https://marc.info/?l=kde-core-devel&m=157566819811019&w=2
The initial discussion how to do that ended with Stephen deciding he rather would want that happen for KF6 only: https://marc.info/?l=kde-frameworks-devel&m=157757468828735&w=2
Given that KF6 is currently actively prepared, hope is something will happen now also for Grantlee. No schedules for that move of Grantlee sadly known or even committed to, in the worst case it will have to be forked if Stephen got no resources here in time :/

@steveire
Copy link
Owner

@ratijas I have not added a .gitignore file because I prefer to see files which shouldn't be there when running git status. Usually those files have ignore rules for *.o etc, which shouldn't be there anyway for out of source builds.

I see your gitignore doesn't have entries like that. The compile-commands.json should be in the build dir instead of the source dir. Why do you have an entry for that? Also, what is the purpose of the others? I think I recall Qt Creator writing a CMakeLists.txt.user file to the source dir, but I don't know if it still does.

@ratijas
Copy link
Author

ratijas commented Dec 29, 2021

Hi @steveire! Glad to see you in this thread.

I believe most of you questions regarding the purpose and reasons for this change are already answered at the linked issue in the first post (which is basically the commit message).

Boiling it down:

  • compile_commands.json is generated in source dir by default by kdesrc-build (I don't personally use it, so I can't judge whether it is the right place, but that's what's happening)
  • which creates unnecessary noise when doing rebuilds.
  • Other common entries are added to gitignore too to reduce tension with popular IDEs.
  • All other equivalent patches to KDE repositories are merged already anyway 😈

@ratijas
Copy link
Author

ratijas commented Dec 29, 2021

I think I recall Qt Creator writing a CMakeLists.txt.user file to the source dir, but I don't know if it still does.

Yes, it sure does. As I wrote in the description, that's what an "average KDE project" marble has in their gitignore, so I assume it would be a sane starting point.

@pcolby pcolby mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants