Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should quote filenames used in tests to avoid empty case #34

Merged
merged 1 commit into from Jan 19, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Dec 27, 2018

If variables used in tests for file existence are empty, they can lead to false positives. For example, commenting out SIGNED_CERT in the default script will cause if [ -f $SIGNED_CERT] to return true. Adding quotes around the variable avoids this issue.

@stevejenkins stevejenkins merged commit 6f0164f into stevejenkins:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.