Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded dependency #1

Merged
merged 1 commit into from Aug 16, 2018
Merged

Remove unneeded dependency #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion IHostedServiceAsAService/IHostedServiceAsAService.csproj
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.1.1" />
<PackageReference Include="System.ServiceProcess.ServiceController" Version="4.5.0" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="2.1.1" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised that I can reduce to just

<ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.1.1" />
  </ItemGroup>

which then brings in both Microsoft.Extensions.Hosting and System.ServiceProcess.ServiceController. Is there a benefit to pulling both in directly?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually seems then I can't resolve HostBuilder, so potentially scratch this query while I check the package graph again!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, yeah I see, brings in only Microsoft.Extensions.Hosting.Abstractions under Microsoft.AspNetCore.Hosting.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what should be added as nuget, Microsoft.AspNetCore.Hosting.WindowsServices or the other two packages ?

</ItemGroup>

Expand Down