Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to create with query parameters #5

Open
patcon opened this issue Sep 6, 2013 · 4 comments
Open

Add option to create with query parameters #5

patcon opened this issue Sep 6, 2013 · 4 comments

Comments

@patcon
Copy link

patcon commented Sep 6, 2013

Thinking that if an issue could be converted by hitting a url with query params, then someone could pretty easily write a userscript to add a button onto the repo's page on github. (This would only work seamlessly after connecting your github account, of course.)

Idea stemmed from isaacs/github#93

@steveklabnik
Copy link
Owner

I like this idea, bur GET shouldnt be used to modify server state...

@patcon
Copy link
Author

patcon commented Sep 6, 2013

You're absolutely right. It felt wrong, so I should have thought about it more. What about just autocompleting the fields? That feels appropriately conservative :)

EDIT: So userscript flow could be:

  1. detects that we are on an issue page
  2. adds nicely styled button for "convert to PR"
  3. On click, polls github API to find candidate branches (in this repo and your forks?)
  4. When user selects one, it redirects them to the appropriate issue2pr url with query params filling in the fields correctly
  5. User clicks button to pull requesterize the issue (and is redirected back to original github page?)

Note, that I haven't done much work with script monkey stuff, so perhaps it's not so simple. The last point would also require a query param for the userscript to store the referring page on github.

@steveklabnik
Copy link
Owner

Yes! Thatd be cool.

@patcon
Copy link
Author

patcon commented Sep 6, 2013

Oops. Updated my comment above -- not sure if it notifies you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants