Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

UI to promote issue to PR #93

Open
chadwhitacre opened this issue Sep 6, 2013 · 14 comments
Open

UI to promote issue to PR #93

chadwhitacre opened this issue Sep 6, 2013 · 14 comments
Labels
cross referencing Interlinking between issues, prs, commits, etc issues pull-requests ui

Comments

@chadwhitacre
Copy link
Collaborator

There's an API for converting an issue into a pull request. This is exposed in hub's pull-request subcommand. It would be aaaaawwwwweeeesssoooommmmeeee to have a web UI for this.

This is my personal number one feature request, hands down.

@chadwhitacre
Copy link
Collaborator Author

Here's the command I used to get the API to work for badges/shields#57:

curl https://api.github.com/repos/gittip/shields.io/pulls \
    -u $PERSONAL_API_TOKEN: \
    -X POST \
    -d'{"issue": "57", "head": "collapse-path-parts", "base": "master"}'

Here's some documentation for personal API tokens.

@chadwhitacre
Copy link
Collaborator Author

I sent an email to support@github.com about this.

@patcon
Copy link

patcon commented Sep 6, 2013

Here's a workaround for now:
http://issue2pr.herokuapp.com/

Helpful to put it in your contributing.md

@chadwhitacre
Copy link
Collaborator Author

@patcon I had trouble with that today, due to the new two-factor auth implementation.

@chadwhitacre
Copy link
Collaborator Author

@mtodd:

Hey Chad,

Thanks for sharing your feature request! We appreciate the feedback.

At GitHub, we prefer creating separate pull requests and then cross referencing the issue that it addresses. In the past, we've encountered problems when issues were turned into pull requests.

One simple example is when the pull request turns out to be the wrong solution and another pull request is more appropriate. In that case, it makes more sense for two separate pulls to both refer to the original issue.

Another example is when an issue's scope is bigger than just one pull request. In this case, several pulls can be created that refer back to the issue which each address different aspects of the overall issue.

Again, thanks for sharing. This has been on our minds and is something we're hoping to address in the future!

Cheers,
Matt

@patcon
Copy link

patcon commented Sep 7, 2013

Hm. That's unfortunate. Seems rather overbearing if that's the official rationale :/

EDIT: When you submit emails, do you also link to the issue that you've created in this repo?

@chadwhitacre
Copy link
Collaborator Author

I couldn't get this working in hub (auth probs?) so I hacked this script: PRomote.sh.

@patcon
Copy link

patcon commented Sep 10, 2013

Nice. FYI, hub --noop pull-request really helps debug when you're just getting used to using it.

Also, might be relevant: mislav/hub#399

Lastly, here's the format for the config file if you want to create it manually:

➜  drupal-monitoring git:(master) ✗ cat ~/.config/hub
--- 
github.com: 
- oauth_token: xxxxxxxxxxxxxxxxxxxxxxx
  user: patcon

@patcon
Copy link

patcon commented Sep 10, 2013

Oh hey, in case anyone missed it, there's talk of a make-do solution here:

steveklabnik/issue2pr#5

@zwn

This comment has been minimized.

@chadwhitacre
Copy link
Collaborator Author

I don't want this anymore. Do I close this ticket or leave it open for others who do?

@patcon
Copy link

patcon commented Dec 11, 2013

I've seen the sentiment elsewhere. Maybe leave it open?

@patcon
Copy link

patcon commented Jan 10, 2014

This is a huge bummer, but it looks like github is discussing whether to deprecate the issue->PR feature :/

mislav/hub@d6b7e1b

@rlidwka
Copy link

rlidwka commented Jan 14, 2014

Oh gosh, why am I finding out features only when they're about to be removed? :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cross referencing Interlinking between issues, prs, commits, etc issues pull-requests ui
Projects
None yet
Development

No branches or pull requests

5 participants