handling bad cookies

steveklabnik · Mar 3, 2009 · 727fa04 · 727fa04
1 parent 245ab10
commit 727fa04
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/History.txt b/History.txt
@@ -1,5 +1,10 @@
 = Mechanize CHANGELOG
 
+=== HEAD
+
+* Bug Fixes:
+  * Fixed a bug with bad cookie parsing
+
 === 0.9.1 2009/02/23
 
 * New Features:

diff --git a/lib/www/mechanize/cookie.rb b/lib/www/mechanize/cookie.rb
@@ -12,11 +12,13 @@ def self.parse(uri, str, log = Mechanize.log)
           first_elem.strip!
           key, value = first_elem.split(/=/, 2)
 
+          cookie = nil
           begin
             cookie = new(key, WEBrick::HTTPUtils.dequote(value))
           rescue
             log.warn("Couldn't parse key/value: #{first_elem}") if log
           end
+          next unless cookie
 
           cookie_elem.each{|pair|
             pair.strip!

diff --git a/test/test_cookie_class.rb b/test/test_cookie_class.rb
@@ -59,6 +59,15 @@ def test_parse_dates
     end
   end
 
+  def test_parse_weird_cookie
+    cookie = 'n/a, ASPSESSIONIDCSRRQDQR=FBLDGHPBNDJCPCGNCPAENELB; path=/'
+    url = URI.parse('http://www.searchinnovation.com/')
+    WWW::Mechanize::Cookie.parse(url, cookie) { |cookie|
+      assert_equal('ASPSESSIONIDCSRRQDQR', cookie.name)
+      assert_equal('FBLDGHPBNDJCPCGNCPAENELB', cookie.value)
+    }
+  end
+
   def test_double_semicolon
     double_semi = 'WSIDC=WEST;; domain=.williams-sonoma.com; path=/'
     url = URI.parse('http://williams-sonoma.com/')