This repository has been archived by the owner on May 20, 2020. It is now read-only.
Do not check subcommands for moved flags #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail CI until #224 is merged |
In b864a9e, the check for moved flags was using `is_present` which checks flags in subcommands. This caused a lot of false positives. Instead, look at the args at the top level only and check if the flag exists there.
hjr3
force-pushed
the
fix-moved-flags-check
branch
from
b2700d8
to
dd91212
Compare
|
Rebased and passing CI now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b864a9e, the check for moved flags was using
is_presentwhichchecks flags in subcommands. This caused a lot of false positives.
Instead, look at the args at the top level only and check if the flag
exists there.