Skip to content

Commit

Permalink
Merge pull request cockroachdb#70028 from itsbilal/disk-full-stop-nod…
Browse files Browse the repository at this point in the history
…e-21.1

[release-21.1] roachtest: Stop node in disk-full roachtest before restarting.
  • Loading branch information
itsbilal committed Sep 10, 2021
2 parents 9e6af3f + a6bf186 commit 8c3c2f2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/cmd/roachtest/disk_full.go
Expand Up @@ -62,6 +62,12 @@ func registerDiskFull(r *testRegistry) {
return nil
}
t.l.Printf("starting %d when disk is full\n", n)
// Pebble treats "no space left on device" as a background error. Kill
// cockroach if it is still running. Note that this is to kill the
// node that was started prior to this for loop, before the ballast
// was created. Now that the disk is full, any subsequent node starts
// must fail with an error for this test to succeed.
_ = c.StopE(ctx, c.Node(n))
// We expect cockroach to die during startup, though it might get far
// enough along that the monitor detects the death.
m.ExpectDeath()
Expand Down

0 comments on commit 8c3c2f2

Please sign in to comment.