Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREADLOCAL is unset when configuring project twice #216

Closed
jpo38 opened this issue Sep 20, 2018 · 2 comments
Closed

THREADLOCAL is unset when configuring project twice #216

jpo38 opened this issue Sep 20, 2018 · 2 comments

Comments

@jpo38
Copy link

jpo38 commented Sep 20, 2018 •
edited
Loading

Run CMake once for Visual Studio, nlopt_config.h contains #define THREADLOCAL __declspec(thread)
Run CMake again, nlopt_config.h contains #define THREADLOCAL

This is because in CMakeLists.txt, HAVE_THREAD_LOCAL_STORAGE is cached but not THREADLOCAL. So on second call to CMake, THREADLOCAL. is not set and remains empty.
jschueller added a commit to jschueller/nlopt that referenced this issue Sep 20, 2018
@jschueller
Fix THREADLOCAL definition
358a991 
Fixes stevengj#216
@jschueller jschueller mentioned this issue Sep 20, 2018
Merged
jschueller added a commit to jschueller/nlopt that referenced this issue Sep 20, 2018
@jschueller
Fix THREADLOCAL definition
0288e32 
Fixes stevengj#216
@jschueller
Copy link
Collaborator

@jpo38 does #217 fix your issue ?

@jpo38
Copy link
Author

jpo38 commented Sep 20, 2018

@jschueller Absolutely!

jschueller added a commit that referenced this issue Sep 20, 2018
@jschueller
Fix THREADLOCAL definition
9586952 
Fixes #216
dand-oss pushed a commit to dand-oss/nlopt that referenced this issue Oct 13, 2018
@jschueller
Fix THREADLOCAL definition
74f19de 
Fixes stevengj#216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jschueller @jpo38