fix EGL and epoxy linking for external projects #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rauch
force-pushed
the
fix_egl_targets
branch
from
7a9facf
to
8f2964b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
INTERFACE_LINK_LIBRARIESforpango_openglcontains the CMake targetsOpenGL::EGLandepoxy::epoxy, which are interpreted as libraries in external projects, unless their packages are imported viafind_packageorfind_dependency. For the OpenGL targets, where the "Find*" macros are available via the original package, this can be fixed by addingfind_dependencyto thePangolinConfig.cmake. However, for epoxy such "Find*" package is not easily available and would need to be manually added by each external project. Hence, we revert back to the old-style CMake includes and libraries, such that theINTERFACE_LINK_LIBRARIESwill contain the path to the shared object for epoxy.Fixes #936.