Maintainer wanted!

[steveruizok]

Hello, I'd like to find a new maintainer for this library. I wrote this port of my JavaScript perfect-freehand algorithm as a learning exercise, however I now see that it has been picked up fairly well within the Flutter community.

If you would like to help maintain the library, please let me know in this issue or at steve@tldraw.com.

Specifically, I'd like to find a maintainer who would be interested in improving its examples, keeping it modern with respect to the Dart language, and keeping it more or less at parity with the JavaScript version. If you'd like to make improvements to the core algorithm, then that would be good too!

Either way, thanks for checking out perfect-freehand, I hope you've found it useful!

[hereket]

Hello. I would love to.

[logickoder]

I would love to be a maintainer

[matthew-carroll]

@steveruizok The Flutter Bounty Hunters are still available to take over the package. We discussed that a little less than a year ago. www.FlutterBountyHunters.com

[bansalgaurav852]

I would love to be a maintainer.

[adil192]

@steveruizok I've re-ported the steveruizok/perfect-freehand repo to dart from scratch.
You can find the repo here: adil192/perfect_freehand

It's therefore fully up to date with the js version. I'm going to do a little bit more testing but I'm planning for this to be a drop-in replacement for steveruizok/perfect-freehand-dart (maybe even replacing the perfect_freehand package on pub.dev).

[steveruizok]

Wow! If this is better than what's here in the repo, I'd be happy to discuss bringing that code here and making you a maintainer.

[adil192]

Update: I've got the demo running now! https://adil192.github.io/perfect_freehand/

[adil192]

I've now added some golden file tests for some of the sample inputs from the js repo.

However, the two_equal_points.png file is blank. Can you help me figure out why?

I found a bug in my repo where trying to normalize the zero vector would return NaN and throw an error. I patched it by simply returning the zero vector if the length is 0: adil192/perfect_freehand@8ea5c5f.
This NaN bug only happened with the two_equal_points.dart sample input, so maybe this could be the culprit?

For the two_equal_parts.dart file, the output is

[Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0), Offset(1.0, 1.0)]

or before the patch it was:

[Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN), Offset(NaN, NaN)]

[adil192]

@steveruizok
I fixed the above edge case with adil192/perfect_freehand@0bb5a99.
I would say my repo is ready to be copied into this repo now if you're ready :)

[alestiago]

What's the status of this? Who is maintaining this repository? Is this still the main repository or has it been moved elsewhere?

[adil192]

What's the status of this? Who is maintaining this repository? Is this still the main repository or has it been moved elsewhere?

Use the package on pub.dev for now.
There aren't any major new features or fixes in the new port, but I believe it has a friendlier API that'll also cut down on wrapper code in dependent projects (like how I needed to implement a StrokeOptions class in Saber).

This (steveruizok/perfect-freehand-dart) is still the main repo. I was waiting for steveruizok's response but I've just made the PR now.
If we can't get the updates merged into this repo, I'll publish it to pub.dev as a separate package.

[steveruizok]

Emailed you @adil192! Sorry all for lack of attention here.

[adil192]

@steveruizok Are we happy to close this issue?