saving signature #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Rajesh, thanks for the PR! I'd like to make this one a bit more useful before I merge it in. At the moment it just seems to render the image again in a new navigation page. Is there any way to save or export the image? I'd also be interested in a way to copy out the stroke to SVG—this is something I've implemented in the perfect-freehand demo for web. |
|
@steveruizok for that you might want to look at some prior-art. The |
UnluckyY1
approved these changes
Feb 15, 2022
adil192
added a commit
that referenced
this pull request
Feb 6, 2024
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'dart:ui/lerp.dart': Failed assertion: line 19 pos 10: '<optimized out>': Cannot interpolate between finite and non-finite values #0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61) #1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5) #2 lerpDouble (dart:ui/lerp.dart:19:10) #3 PointVector.lerp (package:perfect_freehand/src/types/point_vector.dart:54:7) #4 getStrokeOutlinePoints (package:perfect_freehand/src/get_stroke_outline_points.dart:238:31) #5 getStroke (package:perfect_freehand/src/get_stroke.dart:19:10) #6 Stroke._getPolygon (package:saber/components/canvas/_stroke.dart:200:21) #7 Stroke._updatePolygon (package:saber/components/canvas/_stroke.dart:48:16) #8 Stroke.polygon (package:saber/components/canvas/_stroke.dart:38:32) #9 Stroke.toSvgPath (package:saber/components/canvas/_stroke.dart:247:9) #10 EditorExporter.generatePdf.<anonymous closure>.<anonymous closure> (package:saber/data/editor/editor_exporter.dart:111:52) #11 CustomPaint.paint (package:pdf/src/widgets/basic.dart:623:25) #12 SingleChildWidget.paintChild (package:pdf/src/widgets/widget.dart:320:14) #13 ConstrainedBox.paint (package:pdf/src/widgets/basic.dart:449:5) #14 StatelessWidget.paint (package:pdf/src/widgets/widget.dart:260:15) #15 Page.paint (package:pdf/src/widgets/page.dart:246:13) #16 Page.postProcess (package:pdf/src/widgets/page.dart:179:5) #17 Document.save (package:pdf/src/widgets/document.dart:130:14) #18 EditorState.exportAsPdf (package:saber/pages/editor/editor.dart:1213:72) <asynchronous suspension> #19 _ExportBarState._onPressed.<anonymous closure>.<anonymous closure> (package:saber/components/toolbar/export_bar.dart:38:29) <asynchronous suspension>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit to save signature