Merge pull request #2 from manwar/minor-improvements

- Updated how we checked mandatory parameters slightly.
stevieb9 · Feb 12, 2018 · 0593450 · 0593450
2 parents 1948959 + 08b5aba
commit 0593450
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/Github/Backup.pm b/lib/Github/Backup.pm
@@ -60,10 +60,9 @@ sub BUILD {
         $self->token($ENV{GITHUB_TOKEN}) if $ENV{GITHUB_TOKEN};
     }
 
-    for ($self->api_user, $self->token, $self->dir){
-        if (! $_){
-            croak "When instantiating an object, the 'api_user', 'token' and " .
-                  "'dir' parameters are mandatory...\n";
+    for my $key (qw/api_user token dir/){
+        if (! $self->{$key}){
+            croak "ERROR: Missing mandatory parameter [$key].\n";
         }
     }
 
@@ -316,4 +315,3 @@ under the terms of either: the GNU General Public License as published
 by the Free Software Foundation; or the Artistic License.
 
 See L<http://dev.perl.org/licenses/> for more information.
-