Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Updated how we checked mandatory parameters slightly. #2

Merged
merged 1 commit into from Feb 12, 2018
Merged

- Updated how we checked mandatory parameters slightly. #2

merged 1 commit into from Feb 12, 2018

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Feb 12, 2018

Hi @stevieb9

Please review the PR.

Many Thanks.
Best Regards,
Mohammad S Anwar

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.765% when pulling 08b5aba on manwar:minor-improvements into 1948959 on stevieb9:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.765% when pulling 08b5aba on manwar:minor-improvements into 1948959 on stevieb9:master.

@stevieb9 stevieb9 merged commit 0593450 into stevieb9:master Feb 12, 2018
@stevieb9
Copy link
Owner

Thanks Mohammad, this is definitely a more informative and logical way to present the mandatory parameters when they may be missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manwar @coveralls @stevieb9