Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2460 DynamoPSy split & rename #2461

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

2460 DynamoPSy split & rename #2461

wants to merge 19 commits into from

Conversation

oakleybrunt
Copy link
Collaborator

Closes #2460

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (453bfa6) to head (9c130bd).
Report is 53 commits behind head on master.

❗ Current head 9c130bd differs from pull request most recent head 630b4f6

Please upload reports for the commit 630b4f6 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         354      355    +1     
  Lines       48330    48339    +9     
=======================================
+ Hits        48267    48276    +9     
  Misses         63       63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oakleybrunt oakleybrunt changed the title 2461 DynamoPSy split & rename 2460 DynamoPSy split & rename Jan 8, 2024
@oakleybrunt oakleybrunt self-assigned this Feb 20, 2024
@oakleybrunt oakleybrunt added ready for review LFRic Issue relates to the LFRic domain labels Feb 20, 2024
mo-lottieturner
mo-lottieturner requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mo-lottieturner mo-lottieturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly backslashes needing removing

src/psyclone/domain/lfric/lfric_psy.py Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_psy.py Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_psy.py Outdated Show resolved Hide resolved
src/psyclone/dynamo0p3.py Outdated Show resolved Hide resolved
src/psyclone/tests/domain/lfric/lfric_psy_test.py Show resolved Hide resolved
examples/lfric/eg2/loop_fuse_trans.py Outdated Show resolved Hide resolved
examples/lfric/eg2/module_inline_trans.py Outdated Show resolved Hide resolved
examples/lfric/eg2/print_psyir_trans.py Outdated
@@ -46,10 +46,10 @@ def trans(psy):

:param psy: the PSy object that PSyclone has constructed for the \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove backslash

src/psyclone/tests/domain/lfric/lfric_psy_test.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-lottieturner mo-lottieturner Awaiting requested review from mo-lottieturner

Requested changes must be addressed to merge this pull request.

Assignees

@oakleybrunt oakleybrunt

Labels
LFRic Issue relates to the LFRic domain ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Splitting DynamoPSy from dynamo0p3.py
2 participants
@oakleybrunt @mo-lottieturner