Skip to content
This repository has been archived by the owner on Jul 30, 2023. It is now read-only.

Create Crafts & Addition Induction Heater compatability #165

Closed
wants to merge 1 commit into from

Conversation

mrh0
Copy link

@mrh0 mrh0 commented Feb 28, 2021

CC&A adds an Induction Heater that replaces the IE External Heater, this makes the Induction Heater work as a power boost in the EdFurnace class.

CC&A: https://www.curseforge.com/minecraft/mc-mods/createaddition

CC&A adds a Induction Heater which replaces the IE External Heater, this makes the Induction Heater work as a power boost in the EdFurnace class.
@stfwi
Copy link
Owner

stfwi commented Mar 1, 2021

Hey man, thanks for the PR. Let me take a look and reflect on the weekend. Cheers!

@stfwi
Copy link
Owner

stfwi commented Mar 6, 2021

Oky, I double checked and reflected again - and went down a little bit different route by adding a server config for heaters.

 #Tweaks
 [server.tweaks]
 ...
  #Defines (as comma separated list of full registry names) which items are allowed as external heaters in the Aux slot for powered speed boosting.
  furnace_accepted_heaters = "immersiveengineering:furnace_heater,createaddition:heater"
  ...

Reason is (already to be expressed because you made the effort to dig into the code and make a perfectly valid PR) that IE is the primary for this mod, and I'd like to successively replace the few other hardcoded deps with configs (like the old milk bottle thing etc). I put your PR ref into the changelog accordingly. Cheers!

@mrh0
Copy link
Author

mrh0 commented Mar 6, 2021

Thanks, this is great!

@mrh0 mrh0 closed this Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants