Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: call runtime.GC twice in memory profile test #316

Merged
merged 1 commit into from Jul 12, 2021

Commits on Jul 9, 2021

  1. runtime/pprof: call runtime.GC twice in memory profile test

    This change fixes #46500 by working around #45315 which may cause freed
    objects to get missed in the heap profile published for the test.
    
    By calling runtime.GC one more time this change ensures that all freed
    objects are accounted for.
    
    Fixes #46500.
    
    Change-Id: Iedcd0b37dbaffa688b0ff8631a8b79f7a1169634
    Reviewed-on: https://go-review.googlesource.com/c/go/+/333549
    Trust: Michael Knyszek <mknyszek@google.com>
    Run-TryBot: Michael Knyszek <mknyszek@google.com>
    TryBot-Result: Go Bot <gobot@golang.org>
    Reviewed-by: Austin Clements <austin@google.com>
    mknyszek committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ab4085c View commit details
    Browse the repository at this point in the history