net/http: use cancellation instead of a timeout in TestTransportProxy…

[sthagen]

…HTTPSConnectTimeout

The use of a timeout in this test caused it to be flaky: if the
timeout occurred before the connection was attempted, then the Accept
call on the Listener could hang indefinitely, and its goroutine would
not exit until that Listener was closed. That caused the test to fail.

A longer timeout would make the test less flaky, but it would become
even slower and would still be sensitive to timing.

Instead, replace the timeout with an explicit Context cancellation
after the CONNECT request has been read. That not only ensures that
the cancellation occurs at the appropriate point, but also makes the
test much faster: a test run with -count=1000 now executes in less
than 2s on my machine, whereas before it took upwards of 50s.

Fixes golang#36082
Updates golang#28012

Change-Id: I00c20d87365fd3d257774422f39d2acc8791febd
Reviewed-on: https://go-review.googlesource.com/c/go/+/210857
Run-TryBot: Bryan C. Mills bcmills@google.com
Reviewed-by: Brad Fitzpatrick bradfitz@golang.org
TryBot-Result: Gobot Gobot gobot@golang.org

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

• The PR title is formatted as follows: net/http: frob the quux before blarfing
  • The package name goes before the colon
  • The part after the colon uses the verb tense + phrase that completes the blank in,
    "This change modifies Go to ___________"
  • Lowercase verb after the colon
  • No trailing period
  • Keep the title as short as possible. ideally under 76 characters or shorter
• No Markdown
• The first PR comment (this one) is wrapped at 76 characters, unless it's
  really needed (ASCII art, table, or long link)
• If there is a corresponding issue, add either Fixes #1234 or Updates #1234
  (the latter if this is not a complete fix) to this comment
• If referring to a repo other than golang/go you can use the
  owner/repo#issue_number syntax: Fixes golang/tools#1234
• We do not use Signed-off-by lines in Go. Please don't add them.
  Our Gerrit server & GitHub bots enforce CLA compliance instead.
• Delete these instructions once you have read and applied them