Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming for arguments #170

Open
jfmengels opened this issue Sep 10, 2022 · 2 comments
Open

Inconsistent naming for arguments #170

jfmengels opened this issue Sep 10, 2022 · 2 comments

Comments

@jfmengels
Copy link
Collaborator

For functions (in declarations and let declarations), the arguments are under a field named "arguments".
For lambdas, the arguments are under the name "args".

I think we should rename "args" to "arguments" for lambdas.

lenards added a commit to lenards/elm-syntax that referenced this issue Sep 25, 2022
lenards added a commit to lenards/elm-syntax that referenced this issue Sep 25, 2022
@lenards
Copy link

lenards commented Sep 25, 2022

Jeroen, I realize that this is something someone might already have waiting to PR - but I did a quick rename on this:

I did run elm make --docs=docs.json, but I'm not still seeing "args" within the docs.json, so I might not have that handled correctly.

If the above diff looks like what you expected, I can put it up as a pull request.

@lenards
Copy link

lenards commented Sep 25, 2022

(I've been trying to use elm-syntax to help with an i18n extractor; thought I'd try to help out - even if it's really small thing)

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants