updates-for should respect url and only params on each element #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR used to be #182.
Reworked updates-for element to allow per-block url and only attributes. URL fragment indexes are now tracked on a per-URL basis.
That means the following contrived example works as you'd expect:
index.html.erb
updates_for.html.erb
No, I don't know why
Post
has aname
andemail
. Don't ask hard questions.Note that the 4th block will not be updated because
updates_for.html.erb
only has one block; a warning is generated in the console to suggest that there wasn't enough elements for the update to complete.Unfortunately this will certainly clash with #181 as written, although I have done my best to maintain the general structure and naming to ease merge conflicts.