Extract Block class and do a pre-fetch pass #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leastbad
suggested changes
Feb 23, 2022
|
Thanks for getting this pushed through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly this pulls together everything that reaches out to
blockin its own class, and, more importantly, does a pre-pass of fetching unique URLsWhile this is an improvement in general and might fix some of the multi-fetches occurring, I still saw some instances where the same URL was fetched twice,
even from the same elements.What I can say though is that in the app I'm testing it against, we have a fair amount of
touches happening in the class hierarchy, so I think what we're really looking at is another opportunity to look at server side debouncingcc @andrewerlanger