Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_title operation #234

Merged
merged 1 commit into from
Dec 29, 2022
Merged

set_title operation #234

merged 1 commit into from
Dec 29, 2022

Conversation

leastbad
Copy link
Contributor

Type of PR (feature, enhancement, bug fix, etc.)

Feature

Description

cable_ready.set_title(title: "Introducing...")

Why should this be added

@drnic needs a set_title operation, so he gets one.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

@leastbad leastbad added proposal javascript Pull requests that update Javascript code labels Dec 29, 2022
@leastbad leastbad added this to the 5.0 milestone Dec 29, 2022
@leastbad leastbad self-assigned this Dec 29, 2022
@leastbad leastbad merged commit 4aca4b3 into master Dec 29, 2022
@leastbad leastbad deleted the set_title branch December 29, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leastbad leastbad

Labels
javascript Pull requests that update Javascript code proposal
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@leastbad