Scope CableReady custom HTML elements and view helpers #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Consistency Enforcement
Description
Similarly to #250 this pull requests scopes the custom HTML elements and view helpers with the
cable_ready
name.Custom Elements:
<stream-from>
-><cable-ready-stream-from>
<updates-for>
-><cable-ready-updates-for>
There's nothing to migrate here, since those element names were just used under the hood.
CableReady::ViewHelper
view helpersstream_from
->cable_ready_stream_from
updates_for
->cable_ready_updates_for
updates_for_if
->cable_ready_updates_for_if
Why should this be added
The names are super generic and didn't indicate that they were originating from CableReady. Especially the
stream_from
is very confusing, because ActionCable also uses such method.Checklist