Don't raise when including CableReadyHelper
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead print a warning and include the module anyway, so we are not breaking any exisiting code
marcoroth
force-pushed
the
dont-raise-when-including-cablereadyhelper
branch
from
8ff8e71
to
0d53064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
Instead of raising an exception when including the
CableReadyHelpermodule we print a warning and include the rightCableReady::ViewHelpermodule anyway, so we are not breaking any existing code.Why should this be added
This is a much better DX than raising an error and requiring the developer to fix it right away.
Checklist