Fix lingering class-loading issues with CableReady::Updatable concern #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
marcoroth
approved these changes
May 28, 2023
There was a problem hiding this comment.
I'm wondering in which cases the class loading issues are showing up though. I haven't seen them arise in my personal apps, but this looks good to me!
Any concerns @julianrubisch?
julianrubisch
approved these changes
May 28, 2023
|
Ah! I think I was switching between too many branches when testing and one of them was still on |
|
Yeah I was on the wrong branch. Sorry for the false alarm! |
|
Thanks for doubling-checking, @Matt-Yorkley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Description
There's still some weirdness with the way the
MemoryCacheDebounceAdapteris being loaded inCableReady::Updatableconcern. Notes on the previous fix here: #274 (comment)It seems to be resolved now, I'm not seeing the intermittent errors after this tweak 👍
Checklist