Set xpath flag if/when overwriting selector with previous_selector

[Matt-Yorkley]

Bug fix

Description

When chaining operations that use a selector argument, subsequent operations can optionally omit the selector argument and the selector from the previous operation gets applied applied automatically (at line 46 of CableReady::OperationBuilder here.

There's a weird edge case here that can cause the subsequent operation to fail if the first operation was using xpath, because the selector argument gets set but the xpath argument does not get set and defaults to false, eg:

cable_ready
  .add_css_class(name: "example", selector: "/html/body/div[1]", xpath: true) # succeeds
  .inner_html(html: "fail") # fails

The first operation is applied correctly but the inner_html operation fails to find it's element, as it has selector: "/html/body/div[1]", xpath: false, resulting in:

CableReady innerHtml operation failed due to missing DOM element for selector: '/html/body/div[1]`

The DOM element isn't missing, it's just not being looked for with xpath.

Why should this be added

Fixes an obscure edge case when chaining operations using xpath selectors and omitting the selector in subsequent operations.

Checklist

• My code follows the style guidelines of this project
• Checks (StandardRB & Prettier-Standard) are passing

[netlify]

✅ Deploy Preview for cableready ready!

Name	Link
🔨 Latest commit	cf5094a
🔍 Latest deploy log	https://app.netlify.com/sites/cableready/deploys/6476960b826bfd0008b548ca
😎 Deploy Preview	https://deploy-preview-278--cableready.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[marcoroth]

Thank you for taking this one on @Matt-Yorkley!

[julianrubisch]

LGTM 💚

[hopsoft]

NIce catch and fix. 👏🏻